add aspnetcore adapter and samples #381
Conversation
|
@haf can you update travis/appveyor settings, turn |
|
and the failed travis ci caused by Temporarily ignore checks for ci passed, after pr above have been merged and update paket, can revert this ignore check changes |
|
@haf hi, |
|
@lust4life It's just been a lot of xmas here, away from the laptop. Let me read through it. |
| [<AutoOpen;Extension>] | ||
| module ILoggingBuilderExtensions = | ||
|
|
||
| [<Extension>] |
There was a problem hiding this comment.
Better to use CompiledName here, than to use a non-standard method signature for this project; that way, if you use this code from C#, you'll have the NameCasedLikeThis.
There was a problem hiding this comment.
got you. in pr #384 fixed
| { | ||
| "Logging": { | ||
| "LogLevel": { | ||
| "Default": "Warning" |
There was a problem hiding this comment.
Shouldn't this be lower? To let Logary handle the levels?
There was a problem hiding this comment.
there are two ways, let aspnet core pass all message to logary or vice versa, here is aspnet core logging way to handle rules and levels.
| @@ -0,0 +1,28 @@ | |||
| { | |||
There was a problem hiding this comment.
Can this be launched on macOS? (just curious)
There was a problem hiding this comment.
yes, dotnet run this proj, then browser http://localhost:5000/api/TestScope
sorry forget that, and 🎄 merry xmas & happy new year 🎊 |
migrate repo from https://github.com/logary/AspNetCore into logary