Conversation
|
This is good code; I think it needs a test suite, too. |
haf
left a comment
There was a problem hiding this comment.
This;
- needs unit/integration tests like the other targets
- needs to add docs into the readme
- needs to discuss, either in code, or here, how child spans are to be sent and,
- needs to discuss the limitations of the existing code and how it is to be extended
It would be nice to also document how to run a minikube or docker-compose with Jaeger; I'll then test it locally before releasing it.
9183577 to
5b66ed6
Compare
2bf5f4d to
bda50a2
Compare
|
Nice! Do you think you could bump paket as well, and I'll make a new release tonight? |
|
Ping @lapponiandevil — this should interest you |
|
@haf away from laptop few days,
span are created from logger, and inherit before the span finish, every log message produced are belong to this span (if they are flow the execution context and using when target receive a log message (message without
|
limitations:
|
|

it works: