Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement search router state #96

Merged
merged 1 commit into from
May 9, 2024
Merged

Implement search router state #96

merged 1 commit into from
May 9, 2024

Conversation

logashoff
Copy link
Owner

@logashoff logashoff commented May 6, 2024 •
edited
Loading

fixes #98

To do:

  • Prevent font (re)loading on router state change
  • Clear search input when route changes
  • Hide top sites when search is active

@logashoff logashoff force-pushed the search-states branch 8 times, most recently from c5a8c7a to eee16f1 Compare May 6, 2024 21:23
@logashoff logashoff changed the title Implement search state router Implement search router state May 6, 2024
@logashoff logashoff force-pushed the search-states branch 2 times, most recently from c382be8 to 1fdb998 Compare May 7, 2024 13:40
@logashoff logashoff marked this pull request as draft May 7, 2024 13:43
@logashoff logashoff force-pushed the search-states branch 11 times, most recently from 5bb5bae to 084dd35 Compare May 9, 2024 18:04
@logashoff logashoff marked this pull request as ready for review May 9, 2024 18:04
@logashoff logashoff merged commit 12f56ca into master May 9, 2024
1 check passed
@logashoff logashoff deleted the search-states branch May 9, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create separate router states for list and search results
1 participant
@logashoff