Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractLogstashTcpSocketAppender#secondaryConnectionTTL #633

Closed
brenuart opened this issue Sep 6, 2021 · 0 comments · Fixed by #634
Closed

Deprecate AbstractLogstashTcpSocketAppender#secondaryConnectionTTL #633

brenuart opened this issue Sep 6, 2021 · 0 comments · Fixed by #634
Labels
warn/deprecation Changes about to deprecate feature/methods/fields
Milestone

Comments

@brenuart
Copy link
Collaborator

brenuart commented Sep 6, 2021

Property secondaryConnectionTTL belongs to the PreferPrimaryDestinationConnectionStrategy connection strategy and should not be exposed by the AbstractLogstashTcpSocketAppender.

This property has been kept in AbstractLogstashTcpSocketAppender for backwards compatibility purposes from before the connection strategies were implemented in #195 in 4.10. Previously (< 4.10) the concept of a connection strategy did not exist, and secondaryConnectionTTL was a just property on the appender. In 4.10, connection strategies were implemented, and the property remained on the appender for backwards compatibility.

As described in the documentation, the recommended way to configure this property is by setting it directly on the preferPrimary connection strategy as illustrated in the following example:

      <connectionStrategy>
          <preferPrimary>
              <secondaryConnectionTTL>5 minutes</secondaryConnectionTTL>
          </preferPrimary>
      </connectionStrategy>

The property should be deprecated in a backward compatible way and marked for removal in the next major release (8.0).

(see #576 (comment) for more background information)

@brenuart brenuart added the warn/deprecation Changes about to deprecate feature/methods/fields label Sep 6, 2021
brenuart added a commit that referenced this issue Sep 6, 2021
Deprecate AbstractLogstashTcpSocketAppender#secondaryConnectionTTL in a backward compatible way (emit a warning if the propery is set during configuration)

fixes #633
brenuart added a commit that referenced this issue Sep 7, 2021
)

Deprecate `AbstractLogstashTcpSocketAppender#secondaryConnectionTTL` in a backward compatible way (emit a warning if the propery is set during configuration)

fixes #633
@brenuart brenuart added this to the 7.0 milestone Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn/deprecation Changes about to deprecate feature/methods/fields
Projects
None yet
1 participant