Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SequenceJsonProvider to be used with IAccessEvent #661

Closed
brenuart opened this issue Sep 23, 2021 · 1 comment
Closed

Allow SequenceJsonProvider to be used with IAccessEvent #661

brenuart opened this issue Sep 23, 2021 · 1 comment
Labels
type/enhancement
Milestone
7.0

Comments

@brenuart
Copy link
Collaborator

SequenceJsonProvider is currently restricted to ILoggingEvent but may be useful with IAccessEvent as well.
brenuart added a commit that referenced this issue Sep 23, 2021
@brenuart
Make SequenceJsonProvider usable with both ILoggingEvent and IAccessE…
14b43f4 
…vent

Refactor SequenceJsonProvider and associate utility classes to make them usable for both ILoggingEvent and IAccessEvent:
- create a new SequenceJsonProvider by making a copy of the existing SequenceJsonProvider (restricted to ILoggingEvent)
- deprecate the existing SequenceJsonProvider in favour of the new common SequenceJsonProvider
- move LoggingEventJsonProviders#addSequence() method into the common JsonProviders class

Closes #661
@brenuart brenuart mentioned this issue Sep 23, 2021
Merged
@brenuart
Copy link
Collaborator Author

net.logstash.logback.composite.loggingevent.SequenceJsonProvider is now deprecated in favour of the common net.logstash.logback.composite.SequenceJsonProvider. The later is usable for both ILoggingEvent and IAccessEvent.

brenuart added a commit that referenced this issue Sep 29, 2021
@brenuart
Make SequenceJsonProvider usable with both ILoggingEvent and IAccessE…
3f8ad8d 
…vent

Refactor SequenceJsonProvider and associate utility classes to make them usable for both ILoggingEvent and IAccessEvent:
- create a new SequenceJsonProvider by making a copy of the existing SequenceJsonProvider (restricted to ILoggingEvent)
- deprecate the existing SequenceJsonProvider in favour of the new common SequenceJsonProvider
- move LoggingEventJsonProviders#addSequence() method into the common JsonProviders class

Closes #661
@philsttr philsttr added this to the 7.0 milestone Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@brenuart @philsttr