Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license header template for 2022 #766

Closed
brenuart opened this issue Mar 9, 2022 · 5 comments · Fixed by #786
Closed

Update license header template for 2022 #766

brenuart opened this issue Mar 9, 2022 · 5 comments · Fixed by #786
Labels
type/chore A task not related to code (build, formatting, process, ...)

Comments

@brenuart
Copy link
Collaborator

brenuart commented Mar 9, 2022

The license template expects the copyright year to be 2021 - it should be updated to expect 2022 instead.

@brenuart brenuart added the type/chore A task not related to code (build, formatting, process, ...) label Mar 9, 2022
@brenuart
Copy link
Collaborator Author

brenuart commented Mar 9, 2022

Also check why the license header is specified in two places:

  • once in the license plugin (ok)
  • a second time in the checkstyle configuration (why?)

@brenuart
Copy link
Collaborator Author

@philsttr Do you remember any reason why the license header is also enforced by checkstyle in addition to the license maven plugin? It looks like a left over from before we introduced the license plugin and relied solely on checkstyle...

@philsttr
Copy link
Collaborator

I believe it is a leftover.

@brenuart
Copy link
Collaborator Author

Ok. I disabled the check from checkstyle.

@philsttr Another remark: if I'm not updating the files, the license header says the copyright applies from 2013 up to 2021. Does it mean that the files were not "protected" in January and February 2022? I mean wouldn't it be better to use an "open range" for the year - or even avoid including a year?
I don't know... I have no problem with updating all files to increment the date once a year. Just wondering what would happen if the project is "dormant" for a long period of time ;-)

@philsttr
Copy link
Collaborator

philsttr commented Apr 2, 2022

I'm not a lawyer, but I believe they are still protected as long as they aren't changed. I think technically the year only needs to be updated if they are changed. But we can mass-update them if it helps our automation.

@brenuart brenuart linked a pull request Apr 5, 2022 that will close this issue
brenuart added a commit that referenced this issue Apr 5, 2022
* Update license header for year 2022
* Suppress license header check from checkstyle and rely solely on license-maven-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants