Make DelegatingAsyncDisruptorAppender more resilient to exceptions + flush Flushable appenders at end of batch #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rown by child appenders - Wrap calls to appenders within a try/catch block and make sure exceptions thrown by one does not prevent other appenders from receiving the event (gh456). - Flush appenders at end of batch only if they are started (gh456). - OutputStreamAppender may occasionally return a null OutputStream (gh455) - Flush appenders implementing java.io.Flushable (gh454)
philsttr
requested changes
Dec 30, 2020
src/main/java/net/logstash/logback/appender/DelegatingAsyncDisruptorAppender.java
Outdated
Show resolved
Hide resolved
|
Should I close the three related issues or do you prefer to do it yourself after adding the relevant entries in the change log ? |
|
I just closed them. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: