Maven Shade: exclude MANIFEST and produce shaded SOURCE jar #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exclude MANIFEST from shaded jars to make sure we keep only the one from the project in the final result - explicitly configure the plugin to <include> the Disruptor and <exclude> all the other dependencies (if not, new project dependencies will be shaded as well if the plugin configuration is not updated) - produce shaded source as well (handy when debugging applications making use of the library) Related issue: logfellow#553
|
The plugin still issue some warnings after this change: This is caused by the |
…ced pom in the project build directory Related issue: logfellow#555
…ncy reduced pom in the project build directory" This reverts commit 26136d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #553