Implement exponential backoff for the retry strategy #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial retries start very fast (a few nanoseconds pauses) and slow down up to the configure appendRetryTimeout. In addition, limit retry to a single concurrent thread to preserve CPU in constraint environments. These changes should give a better througput when the queue is full.
philsttr
reviewed
Aug 28, 2021
| @@ -259,13 +260,18 @@ | |||
| * Delay between consecutive attempts to append an event in the ring buffer when | |||
| * full. | |||
| */ | |||
| private Duration appendRetryFrequency = Duration.buildByMilliseconds(50); | |||
| private Duration appendRetryFrequency = Duration.buildByMilliseconds(5); | |||
There was a problem hiding this comment.
5ms seems really fast.
What is the reasoning behind this value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial retries start very fast (a few nanoseconds pauses) and slow down up to the configure
appendRetryTimeout.In addition, limit retry to a single concurrent thread to preserve CPU in constraint environments.
These changes should give a better throughput with an acceptable latency when the queue is full.
Closes #619