Attempt to fix unstable AsyncDisruptorAppenderTest#testEventHandlerCalled test case #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not reproduce the issue locally. I suspect some nasty concurrent issues with Mockito... Decided to rewite the test case entirely with concrete classes instead of Mockito. Hope it helps...
brenuart
force-pushed
the
gh586-unstable-asyncdisruptortest
branch
2 times, most recently
from
b098fd3
to
3a7d8e6
Compare
…ption We need to wait for the exception handler to have processed the exception to determine when async processing is completed. Waiting for the event handler is not enough...
brenuart
force-pushed
the
gh586-unstable-asyncdisruptortest
branch
from
3a7d8e6
to
9b06449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the issue locally. I suspect some nasty concurrent issues with Mockito... Decided to rewite the test case entirely with concrete classes instead of Mockito. Hope it helps...
Closes #586