Throw IllegalArgumentException at invalid time zone textual representation instead of defaulting to GMT #655
Conversation
…ation instead of defaulting to GMT Issue #650
| * between 00 to 59. For example, "GMT+10" and "GMT+0010" mean ten | ||
| * hours and ten minutes ahead of GMT, respectively. | ||
| * | ||
| * <p>Use a blank string or {@code null} to use the default TimeZone of the system. |
There was a problem hiding this comment.
Joran does not allow to set a blank string nor a null value... May be we need another way here for the user to say it wants the default time zone of the system...?
User can of course not set the property and keep the default value... but what if he wants to explicitly set a value and not rely on the default?
There was a problem hiding this comment.
Adding a special case for "DEFAULT" seems ok to me.
There was a problem hiding this comment.
[DEFAULT] can now be used to refer to the system default time zone (between brackets to follow same convention as used by the pattern property of the same class).
Since Joran does not allow to set an empty string or a null value, I also removed these mentions in the documentation. These options are still supported tho and are documented in the javadoc for use by programmatic configuration if someone wants to go that road.
| * between 00 to 59. For example, "GMT+10" and "GMT+0010" mean ten | ||
| * hours and ten minutes ahead of GMT, respectively. | ||
| * | ||
| * <p>Use a blank string or {@code null} to use the default TimeZone of the system. |
There was a problem hiding this comment.
Adding a special case for "DEFAULT" seems ok to me.
Closes #650.