Use a ThreadLocal approach instead of an ObjectPool #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenuart
force-pushed
the
threadlocal-instead-of-ObjectPool
branch
from
71823ab
to
feefdb4
Compare
Track threads and allocated values. Dispose value when a thread dies. Dispose allocated values on close()
brenuart
force-pushed
the
threadlocal-instead-of-ObjectPool
branch
from
feefdb4
to
6d53115
Compare
brenuart
force-pushed
the
threadlocal-instead-of-ObjectPool
branch
from
1955c40
to
1fce722
Compare
philsttr
approved these changes
Oct 11, 2021
src/main/java/net/logstash/logback/composite/JsonProviders.java
Outdated
Show resolved
Hide resolved
philsttr
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a ThreadLocal approach instead of an ObjectPool to provide a thread-safe value to requesting threads.
The ThreadLocalHolder class maintains a per-thread value using an internal ThreadLocal variable. Values are obtained from the Supplier given to the constructor at initialisation time.
It also maintains a WeakReference to each requesting thread and record the value given to it. As opposed to a standard ThreadLocal, the holder automatically dispose the value when the owning thread dies and sets its reference to null to make it eligible for garbage collection. This process hooks into the #release() method and is therefore executed every time a thread releases its value.
Finally, all allocated values are disposed when the ThreadLocalHolder is closed.
Related to issue #630.