Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when shortenedLoggerNameLength is set to 0 (zero) #748

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

brenuart
Copy link
Collaborator

ClassNameOnlyAbbreviator should be used instead of TargetLengthBasedClassNameAbbreviator when the desired length is set to 0.

Closes #747

`ClassNameOnlyAbbreviator` should be used instead of `TargetLengthBasedClassNameAbbreviator` when the desired length is set to `0`.

Closes #747
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #748 (fa64615) into main (0e770cb) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #748      +/-   ##
============================================
+ Coverage     70.45%   70.53%   +0.07%     
- Complexity     1223     1228       +5     
============================================
  Files           162      162              
  Lines          4719     4728       +9     
  Branches        481      481              
============================================
+ Hits           3325     3335      +10     
+ Misses         1147     1146       -1     
  Partials        247      247              
Impacted Files Coverage Δ
...composite/loggingevent/LoggerNameJsonProvider.java 95.83% <100.00%> (+15.83%) ⬆️
...h/logback/composite/FastISOTimestampFormatter.java 95.23% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e770cb...fa64615. Read the comment docs.

@brenuart brenuart merged commit 33c5c9f into main Jan 24, 2022
@brenuart brenuart deleted the gh747-shorten-logger-name branch January 24, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable simple class name in logger name customization
1 participant