Support for Timestamp with nanosecond precision (logback 1.3+) #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Detect at runtime which version of Logback ins used. If version 1.3, get timestamp by calling the new `ILoggingEvent#getInstant()` method which provides nanoseconds precision. If version before 1.3, get the timestamp by calling the older `IloggingEvent#getTimeStamp()` method which gives only milliseconds precision. * Use an Instant internally whatever version of Logback is used. Adapt TimestampJsonProvider and the associated FastIOSTimestampFormatter to accept Instant with nano precision instead of a long millis.
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
============================================
- Coverage 70.97% 70.90% -0.08%
- Complexity 1255 1258 +3
============================================
Files 167 168 +1
Lines 4807 4816 +9
Branches 498 502 +4
============================================
+ Hits 3412 3415 +3
- Misses 1150 1153 +3
- Partials 245 248 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
philsttr
changed the title
philsttr
added
the
warn/behavior-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the new
ILoggingEvent#getInstant()method introduced in Logback 1.3 to provide timestamp with nanoseconds precision.closes #829