Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Event#getSequenceNumber (logback 1.3+) #843

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

brenuart
Copy link
Collaborator

closes #830

The existing SequenceJsonProvider is enhanced to adapt its behaviour depending on which version of Logback is found on the class path:

  • Logback >= 1.3: get the sequence value from the event itself as long as a SequenceNumberGenerator is defined in the LoggerContext. If not, revert to using a locally incremented sequence number (previous behaviour)
  • Logback < 1.3: use a locally incremented sequence number

Better to determine version from a “logback-core” class -> one of classic/access may not be on the classpath…

Note: this strategy assumes that Logback jars are aligned on the same version…
@brenuart brenuart linked an issue Aug 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #843 (8e45af7) into main (c126999) will decrease coverage by 0.03%.
The diff coverage is 75.75%.

@@             Coverage Diff              @@
##               main     #843      +/-   ##
============================================
- Coverage     70.84%   70.80%   -0.04%     
- Complexity     1261     1270       +9     
============================================
  Files           168      170       +2     
  Lines          4829     4854      +25     
  Branches        505      507       +2     
============================================
+ Hits           3421     3437      +16     
- Misses         1155     1161       +6     
- Partials        253      256       +3     
Impacted Files Coverage Δ
.../net/logstash/logback/composite/JsonProviders.java 90.47% <ø> (-0.44%) ⬇️
...gstash/logback/composite/SequenceJsonProvider.java 100.00% <ø> (ø)
...omposite/accessevent/AccessEventJsonProviders.java 67.56% <0.00%> (-3.87%) ⬇️
...ck/composite/accessevent/SequenceJsonProvider.java 0.00% <0.00%> (ø)
...n/java/net/logstash/logback/util/LogbackUtils.java 40.00% <50.00%> (ø)
...ogback/composite/AbstractSequenceJsonProvider.java 86.95% <86.95%> (ø)
...posite/loggingevent/LoggingEventJsonProviders.java 87.23% <100.00%> (+0.56%) ⬆️
...k/composite/loggingevent/SequenceJsonProvider.java 100.00% <100.00%> (ø)
...ck/appender/AbstractLogstashTcpSocketAppender.java 69.23% <0.00%> (-0.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brenuart brenuart merged commit 6e4c98e into main Aug 23, 2022
@brenuart brenuart deleted the 830-add-support-for-eventgetsequencenumber-logback-13 branch August 23, 2022 11:40
@brenuart brenuart changed the title Add support for Event#getsequencenumber (logback 13) Add support for Event#getSequenceNumber (logback 13) Aug 23, 2022
@philsttr philsttr added the warn/behavior-change Breaking change of publicly advertised behavior label Feb 20, 2023
@philsttr philsttr changed the title Add support for Event#getSequenceNumber (logback 13) Add support for Event#getSequenceNumber (logback 1.3+) Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for event.getSequenceNumber() (logback 1.3)
2 participants