Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortenedThrowableConverter: <exclude> and <exclusions> are mutually exclusive (#876) #881

Conversation

brenuart
Copy link
Collaborator

See #876

…eplacing content

Also add a common utility method in Stringutils to convert a comma delimited list of strings into an array.
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #881 (f8e81ca) into main (914400c) will increase coverage by 0.27%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #881      +/-   ##
============================================
+ Coverage     71.58%   71.86%   +0.27%     
- Complexity     1309     1331      +22     
============================================
  Files           170      170              
  Lines          4910     4929      +19     
  Branches        514      519       +5     
============================================
+ Hits           3515     3542      +27     
+ Misses         1147     1141       -6     
+ Partials        248      246       -2     
Impacted Files Coverage Δ
...ogback/stacktrace/ShortenedThrowableConverter.java 80.90% <18.18%> (-1.39%) ⬇️
...in/java/net/logstash/logback/util/StringUtils.java 96.87% <94.73%> (+96.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brenuart brenuart merged commit 7ebd6b2 into main Oct 16, 2022
@brenuart brenuart deleted the 876-shortenedthrowableconverter-exclude-and-exclusions-are-mutually-exclusive branch October 16, 2022 21:45
@philsttr philsttr added type/bug warn/behavior-change Breaking change of publicly advertised behavior labels Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShortenedThrowableConverter: <exclude> and <exclusions> are mutually exclusive
2 participants