Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortenedThrowableConverter: add option to set my own custom abbreviator #893

Conversation

brenuart
Copy link
Collaborator

@brenuart brenuart commented Nov 7, 2022

No description provided.

@brenuart brenuart force-pushed the 877-shortenedthrowableconverter-add-option-to-set-my-own-custom-abbreviator branch from fb0316f to a1c21ef Compare November 7, 2022 13:07
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #893 (a1c21ef) into main (e1c6129) will decrease coverage by 0.22%.
The diff coverage is 67.90%.

@@             Coverage Diff              @@
##               main     #893      +/-   ##
============================================
- Coverage     71.79%   71.56%   -0.23%     
- Complexity     1334     1347      +13     
============================================
  Files           170      173       +3     
  Lines          4939     4984      +45     
  Branches        520      518       -2     
============================================
+ Hits           3546     3567      +21     
- Misses         1149     1164      +15     
- Partials        244      253       +9     
Impacted Files Coverage Δ
.../java/net/logstash/logback/CachingAbbreviator.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/net/logstash/logback/NullAbbreviator.java 0.00% <0.00%> (-100.00%) ⬇️
...composite/loggingevent/LoggerNameJsonProvider.java 61.53% <28.57%> (-34.30%) ⬇️
...ogback/stacktrace/ShortenedThrowableConverter.java 79.03% <50.00%> (-1.87%) ⬇️
...n/java/net/logstash/logback/util/LogbackUtils.java 64.70% <75.00%> (+24.70%) ⬆️
...ck/abbreviator/DefaultTargetLengthAbbreviator.java 92.00% <92.00%> (ø)
...gstash/logback/abbreviator/CachingAbbreviator.java 100.00% <100.00%> (ø)
.../logstash/logback/abbreviator/NullAbbreviator.java 100.00% <100.00%> (ø)
...h/logback/composite/FastISOTimestampFormatter.java 94.89% <0.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brenuart brenuart merged commit 6bd910b into main Nov 7, 2022
@brenuart brenuart deleted the 877-shortenedthrowableconverter-add-option-to-set-my-own-custom-abbreviator branch November 7, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShortenedThrowableConverter: add option to set my own custom Abbreviator
2 participants