Add ability to customize the PrettyPrinter #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to customize the PrettyPrinter used by PrettyPrintingJsonGeneratorDecorator.
Specifically, add rootSeparator and spacesInObjectEntries fields.
Change default root value separator used by the PrettyPrinter to an empty string to match the default rootValueSeparator used by the formatters.
Previously, the default was a space (" "). So this will slightly change the output when the PrettyPrintingJsonGeneratorDecorator is used.
To revert to the old behavior, configure the decorator like this:
<jsonGeneratorDecorator class="net.logstash.logback.decorate.PrettyPrintingJsonGeneratorDecorator">
<rootSeparator>[SPACE]</rootSeparator>
</jsonGeneratorDecorator>
Requested in discussion #906
philsttr
added
type/enhancement
warn/api-change
philsttr
added
warn/behavior-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to customize the
PrettyPrinterused byPrettyPrintingJsonGeneratorDecorator.Specifically, add
rootSeparatorandspacesInObjectEntriesfields.Change default root separator used by the
PrettyPrinterto an empty string to match the defaultrootValueSeparatorused by the formatters. Previously, the default was a space (" "). So this will slightly change the output when thePrettyPrintingJsonGeneratorDecoratoris used. To revert to the old behavior, configure the decorator like this:Requested in discussion #906