-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MDC entry writers to be able to convert values #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I really like the approach you came up with. I have some feedback on naming and some low level implementation details. But in general, the design is solid.
src/main/java/net/logstash/logback/composite/loggingevent/mdc/BooleanMdcFieldConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/LongMdcFieldConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/DoubleMdcFieldConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/MdcField.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/MdcField.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/MdcFieldConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/net/logstash/logback/composite/loggingevent/mdc/MdcFieldConverter.java
Outdated
Show resolved
Hide resolved
* add protected method to allow manipulating output of MDC entry * change visibility to MDC config attributes
* add LogstashEncoder configuration to add MdcEntryWriters * add MDC entry writers for Long, Double & Boolean values
221b1f0
to
347c6db
Compare
More documentation. Avoid regex for matching long. Use regex recommended by Java for matching doubles. Make some internal methods private .
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
============================================
+ Coverage 71.64% 71.78% +0.14%
- Complexity 1386 1417 +31
============================================
Files 174 177 +3
Lines 5113 5178 +65
Branches 528 534 +6
============================================
+ Hits 3663 3717 +54
- Misses 1189 1197 +8
- Partials 261 264 +3
|
Thanks for the quick turnaround on my review comments! This will be included in the next release (soon) |
Solution proposal for issue #955