Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSTORE-1389] get_secrets_api and create_project should be accessible as hopsworks module functions #202

Merged
merged 5 commits into from
May 10, 2024
Merged

[FSTORE-1389] get_secrets_api and create_project should be accessible as hopsworks module functions #202

merged 5 commits into from
May 10, 2024

Conversation

robzor92
Copy link
Collaborator

@robzor92 robzor92 commented May 7, 2024

No description provided.

@robzor92 robzor92 force-pushed the FSTORE-1389 branch 3 times, most recently from b062e6b to 6beb48f Compare May 10, 2024 08:02
@robzor92 robzor92 requested a review from vatj May 10, 2024 08:31
vatj
vatj approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@vatj vatj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe you can add a show_project_list to hopsworks module? In the spirit of not having to go check in the UI

@robzor92 robzor92 merged commit 8826a76 into logicalclocks:main May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vatj vatj vatj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robzor92 @vatj