-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Model Serving #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I was mostly confused about model serving vs deployment vs model serving infrastructure. I think you were consistent, so you might want to ignore a few of the suggestions at the beginning of my review with changing model serving to deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general there are a few broken links, especially in the model registry part which I think happened after the refactoring of the structure. Also the API reference is missing information about creation. We should follow a similar structure as https://docs.hopsworks.ai/hopsworks-api/2.6.0-SNAPSHOT/generated/api/jobs/ when it comes to creating an object like a deployment. So first a "Handle" section to get the ModelServing object, and then a "Creation" section for what operation is done to create a deployment. So model.deploy()
or ms.create_deployment()
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
No description provided.