Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More file structure improvements #11

Closed
yzen opened this issue Jul 5, 2012 · 3 comments
Closed

More file structure improvements #11

yzen opened this issue Jul 5, 2012 · 3 comments

Comments

@yzen
Copy link

yzen commented Jul 5, 2012

Hi Gaurav,

  • I was wondering if it is necessary to duplicate some of the templates specific to UIOptions. I noticed you have non-epub templates in html/uiOptions folder that are also present in the "proper" location infusion/components/uiOptions/html.
  • Also, you still have JSZip and Infusion at the top level, rather than in lib folder, I think it makes sense to group those in there.
@logiclord
Copy link
Owner

Hi Yura,

I will be cleaning of directory structure in my next commit. I kept most of
those templates while experimenting with UI Options. I really don't need
layout and link template while I am using same Textual template as in
infusion, rest are of my own.

I will ping you when I am done so that you can review most updated code.

On Thu, Jul 5, 2012 at 7:26 PM, Yura Zenevich <
reply@reply.github.com

wrote:

Hi Gaurav,

  • I was wondering if it is necessary to duplicate some of the templates
    specific to UIOptions. I noticed you have non-epub templates in
    html/uiOptions folder that are also present in the "proper" location
    infusion/components/uiOptions/html.
  • Also, you still have JSZip and Infusion at the top level, rather than in
    lib folder, I think it makes sense to group those in there.

Reply to this email directly or view it on GitHub:
https://github.com/logiclord/web-based-epub-reader/issues/11

Regards,

Gaurav Aggarwal
Final year Student,
Delhi College of Engineering

@yzen
Copy link
Author

yzen commented Jul 5, 2012

Great, I just had some time to check it out and give some suggestions. I like what you did with the component structure in the epub reader code, by the way!

@logiclord
Copy link
Owner

I have changed the file structure. Please confirm about new file structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants