Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bit width drop-down lists #771

Closed
R3dst0ne opened this issue Jul 4, 2021 · 3 comments
Closed

Bit width drop-down lists #771

R3dst0ne opened this issue Jul 4, 2021 · 3 comments
Labels
all OS enhancement good first issue pri -1 Not that crucial (lower priority)

Comments

@R3dst0ne
Copy link
Contributor

R3dst0ne commented Jul 4, 2021

[...] since the increase to 64-bit wide busses, using drop-down lists to choose the bit width and selecting bits is tedious, [...]

By @maehne in #617 (comment)
@maehne maehne added all OS enhancement good first issue pri -1 Not that crucial (lower priority) labels Jul 5, 2021
@MarcinOrlowski
Copy link
Member

MarcinOrlowski commented Jul 5, 2021 •
edited

I think the good solution for that would be combo widget, containing of widget where user can enter whatever value s/he needs but also accompanying with drop-down "presets" to select for (and I do not think that it makes sense to list all possible values but the most popular ones (based on no random guess): 1-8, 16, 24, 32, 64 (in drop down).

@maehne
Copy link
Member

maehne commented Jul 7, 2021

Yes, that could be a convenient solution.

dtowell added a commit to dtowell/logisim-evolution that referenced this issue Sep 21, 2022
@dtowell
Issue logisim-evolution#771
a5abed1 
All BitWidth attributes now allow text entry of the number in addition to a smaller drop down menu. There are now three modes:

    A range is not specified, therefore 1-64 (Value.MAX_WIDTH) is allowed. The menu allows 1..8,16,24,32,64; other values can be entered via the keyboard. This used to display all 64 values via a scrolling menu.
    A range of 12 or fewer options is specified. The menu allows all options; they can also be entered via the keyboard. This behavior did not change.
    A range of more than 12 options are specified. No menu is created; values must be entered via the keyboard. This used to display all possible values in the menu, possibly scrolling.

The "prefab" mechanism was slightly enhanced, reducing the number of redundant objects created.
dtowell added a commit to dtowell/logisim-evolution that referenced this issue Sep 22, 2022
@dtowell
Revert "Issue logisim-evolution#771"
68f8e8c 
This reverts commit a5abed1.
dtowell added a commit to dtowell/logisim-evolution that referenced this issue Sep 22, 2022
@dtowell
issue logisim-evolution#771
1813f56
BFH-ktt1 added a commit that referenced this issue Sep 24, 2022
@BFH-ktt1
Merge pull request #1543 from dtowell/#771
3e1efb0 
improve BitWidth UI
@R3dst0ne
Copy link
Contributor Author

R3dst0ne commented Oct 6, 2022

Closing since #1543 got merged.

@R3dst0ne R3dst0ne closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
all OS enhancement good first issue pri -1 Not that crucial (lower priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maehne @MarcinOrlowski @R3dst0ne