Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: [Collision Monitor] Add a watchdog mechanism #55

Merged
merged 3 commits into from Jan 19, 2024

Conversation

jplapp
Copy link

@jplapp jplapp commented Jan 17, 2024


Basic Info

Info Please fill out this column
Ticket(s) this addresses ros-navigation#3879, ros-navigation#3880, https://lvserv01.logivations.com/browse/AMRNAV-6228
Primary OS tested on Ubuntu
Robotic platform tested on gazebo sim

Backports ros-navigation#3879 and ros-navigation#3880

Related deep_cv PR: https://github.com/logivations/deep_cv/pull/7252

Tony Najjar and others added 3 commits January 17, 2024 08:32
* Rename PushRosNamespace to PushROSNamespace

* Fix min_points checking

* .

* fixes

* add to collision detector

* fix

* fix

* .

* fixes

* add namespace to topic

* fixes

(cherry picked from commit c0fd78f)
* Add block_if_invalid and allow sensor specific  source_timeout

* remove block_if_invalid param and make it default behavior

* allow unblocking if data not yet published

* log source name when invalid

* getData return true if invalid AND source_timeout == 0.0

* fixed logic without source feedback

* fix test

* rebase artefact

* format artefact

* better log

* move per sensor param source_timeout logic to source.cpp

* fix ignore invalid source behavior

* add source_timeout tests

* no needed anymore

* fix testSourceTimeoutOverride test

---------

Co-authored-by: Guillaume Doisy <guillaume@dexory.com>

(cherry picked from commit 0f72da2)
@HovorunB HovorunB changed the title Backport source timeout Backport: [Collision Monitor] Add a watchdog mechanism Jan 18, 2024
@HovorunB HovorunB self-assigned this Jan 18, 2024
@HovorunB HovorunB merged commit 229a6d4 into iron Jan 19, 2024
@HovorunB HovorunB deleted the backport_source_timeout branch January 19, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants