Use awaiting connect for services relay #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
reviewed
Oct 17, 2023
Yes, this was meant to be a draft PR, but somehow couldn't make it a draft 🤔 |
|
Ahh no prob, I saw that you requested reviews and thought it was ready |
danielSanchezQ
force-pushed
the
relay-ready
branch
from
a138f5e
to
a38609f
Compare
|
Closing in favor of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to add a mechanism so a service that depends on another service knows when this other one is available. At the moment we stablish a connection between them (A => B) and the the service B replies whenver message arrives, but A has no way of knowing when is this. The firt attemp is to add a signal wrapper around relays (inbound/outbound) that will just return the
OutboundRelaywhen the service has been initialize.This said: The current approach in this PR is not working. Reason is that RelayState wrappers lose messages (state) when clonning, that makes that they may lose the first (and only) signal and keep waiting forever (?)