fix large msg sending logic #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simulations/src/network/mod.rs
Outdated
Comment on lines
285
to
296
| if should_delay { | ||
| let mut cap = node_capacity.current_load.lock(); | ||
| let sent = node_capacity.capacity_bps - *cap; | ||
| *cap = node_capacity.capacity_bps; | ||
| if message.partial_send(sent) == 0 { | ||
| let to_node = self.to_node_senders.get(&to).unwrap(); | ||
| to_node | ||
| .send(message.clone()) | ||
| .expect("node should have connection"); | ||
| node_capacity.decrease_load(sent); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Nitpick: can we put this in a named method?
danielSanchezQ
force-pushed
the
simulation-msg
branch
from
081b7f5
to
40453b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @bacv, the problem with the current network throughput is if the message size is bigger than the calculated step throughput, then it never gets sent.
The solution in this PR is "partial send":
e.g.
Let's say, if we have a large message with size 15, and the throughput is 5. In the first step, we mock partially send behavior, so send 5 (remaining message size is 10). In the second step, partially send another 5 (the remaining message size is 5). In the third step, we send the final 5, so the large message can be sent through 3 steps in total.