Small additions to libp2p #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zeegomo
commented
Jul 31, 2023
zeegomo
commented
- Add initial peer config to nomos-libp2p
- Use custom message id to avoid duplicates
- Expose reference to the inner swarm
danielSanchezQ
approved these changes
Jul 31, 2023
nomos-libp2p/src/lib.rs
Outdated
Comment on lines
91
to
97
| .message_id_fn(|message| { | ||
| use blake2::digest::{consts::U32, Digest}; | ||
| use blake2::Blake2b; | ||
| let mut hasher = Blake2b::<U32>::new(); | ||
| hasher.update(&message.data); | ||
| gossipsub::MessageId::from(hasher.finalize().to_vec()) | ||
| }) |
There was a problem hiding this comment.
Nitpick: Can we make a function for this?
zeegomo
added a commit
that referenced
this pull request
Aug 3, 2023
* Add initial peer config to nomos-libp2p * Use custom message id to avoid duplicates * Expose reference to the inner swarm * move closure into function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.