Small fixes for libp2p network backend #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al8n
reviewed
Jul 31, 2023
Waku does that and it's kind of convenient not to handle ourselves in a different way from the rest.
When receiving messages coming from libp2p IWANT requests, it's common to receive a burst of packest which can cause subscribers to lag. To account for that, let's increase the buffer in the broadcast channel.
zeegomo
force-pushed
the
libp2p-self-notif
branch
from
c88d4ce
to
1a2f116
Compare
youngjoon-lee
approved these changes
Aug 4, 2023
zeegomo
added a commit
that referenced
this pull request
Aug 7, 2023
* Generate network events for self messages Waku does that and it's kind of convenient not to handle ourselves in a different way from the rest. * Use bigger buffer + fmt When receiving messages coming from libp2p IWANT requests, it's common to receive a burst of packest which can cause subscribers to lag. To account for that, let's increase the buffer in the broadcast channel. * Check if topic is being subscribed before self-notification (#292) * fmt --------- Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.