-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for libp2p backend in integration tests #287
Conversation
Yes, integration job builds I can add updated jenkinsfile to this PR or create a new one, which do you prefer? |
@@ -8,12 +8,17 @@ use consensus_engine::overlay::{FlatOverlaySettings, RoundRobin}; | |||
use consensus_engine::NodeId; | |||
use nomos_consensus::{CarnotInfo, CarnotSettings}; | |||
use nomos_http::backends::axum::AxumBackendSettings; | |||
#[cfg(feature = "libp2p")] | |||
use nomos_libp2p::Multiaddr; | |||
use nomos_libp2p::SwarmConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be in one line for the feature flag.
use nomos_libp2p::{Multiaddr, SwarmConfig};
wouldn't the |
It won't work for building two separate binary files. It might work for |
Backends are mutually exclusive, we actually want duplication here so that we run one time with waku and one time with libp2p. |
Right now we use |
Ideally, we should test both version in integrations tests, I think it's possible to set up a run for each of the backends right @bacv ?