-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using CSV format by default for simulations #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the performance improved?
The changes in this PR seem not to improve the performance. However, I found several small places about serialization (mainly about avoiding deep clones and the serialization output format) that can be optimized. I will make more small PRs to optimize them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix needed for csv writer, otherwise looks good.
When application uses |
I like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, all fields serializes as it should in json and csv, amazing work. 🚀
I suppose using CSV format by default should be straightforward, but unfortunately, I forgot that complex structs and vec (nested with struct) are not supported by
csv
crate. I solve this problem by manually implementingCarnotState::serialize
deeper and adding a newRecord
type.