Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwatch mixnet node #339

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Overwatch mixnet node #339

merged 2 commits into from
Aug 30, 2023

Conversation

danielSanchezQ
Copy link
Collaborator

Wrap the mixnet node with Overwatch.
Other services like log can be added later.

@danielSanchezQ danielSanchezQ added this to the Mixnet milestone Aug 29, 2023
@danielSanchezQ danielSanchezQ self-assigned this Aug 29, 2023
@al8n al8n changed the base branch from master to mixnet August 29, 2023 16:10
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@youngjoon-lee youngjoon-lee self-requested a review August 30, 2023 02:54
@danielSanchezQ
Copy link
Collaborator Author

Errors are not related I think.
@youngjoon-lee thanks for the fix. Can we go merge it even with CI failing?

@youngjoon-lee youngjoon-lee linked an issue Aug 30, 2023 that may be closed by this pull request
@youngjoon-lee
Copy link
Contributor

Errors are not related I think. @youngjoon-lee thanks for the fix. Can we go merge it even with CI failing?

I will fix this error from CI.

     Running src/tests/happy.rs (target/debug/deps/test_consensus_happy_path-64c20b5895100dc5)

running 2 tests
Error: Error("missing field `mixnode`", line: 1, column: 1)
Error: Error("missing field `mixnode`", line: 1, column: 1)
Error: Error("missing field `mixnode`", line: 1, column: 1)
Error: Error("missing field `mixnode`", line: 1, column: 1)
Error: Error("missing field `mixnode`", line: 1, column: 1)
thread 'Overwatch' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError(())', nodes/nomos-node/src/bridges/libp2p.rs:23:31

Even if we fix this, CI will fail until we merge #335 (I think we can merge).

@danielSanchezQ danielSanchezQ merged commit 33a4823 into mixnet Aug 30, 2023
0 of 2 checks passed
@youngjoon-lee youngjoon-lee deleted the overwatch-mixnet-node branch September 1, 2023 00:21
youngjoon-lee added a commit that referenced this pull request Sep 14, 2023
* Add `mixnode` and `mixnet-client` crate (#302)

* Add `mixnode` binary (#317)

* Integrate mixnet with libp2p network backend (#318)

* Fix #312: proper delays (#321)

* proper delays

* add missing duration param

* tiny fix: compilation error caused by `rand` 0.8 -> 0.7

* use `get_available_port()` for mixnet integration tests (#333)

* add missing comments

* Overwatch mixnet node (#339)

* Add mixnet service and overwatch app

* remove #[tokio::main]

---------

Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>

* fix tests for the overwatch mixnode (#342)

* fix panic when corner case happen in RandomDelayIter (#335)

* Use `log` service for `mixnode` bin (#341)

* Use `wire` for MixnetMessage in libp2p (#347)

* Prevent tmixnet tests from running forever (#363)

* Use random delay when sending msgs to mixnet (#362)

* fix a minor compilation error caused by the latest master

* Fix run output fd (#343)

* add a connection pool

* Exp backoff (#332)

* move mixnet listening into separate task

* add exponential retry for insufficient peers in libp2p

* fix logging

* Fix MutexGuard across await (#373)

* Fix MutexGuard across await

Holding a MutexGuard across an await point is not a good idea.
Removing that solves the issues we had with the mixnet test

* Make mixnode handle bodies coming from the same source concurrently (#372)

---------

Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>

* Move wait at network startup (#338)

We now wait after the call to 'subscribe' to give the network
the time to register peers in the mesh before starting to
publish messages

* Remove unused functions from mixnet connpool (#374)

* Mixnet benchmark (#375)

* merge fixes

* add `connection_pool_size` field to `config.yaml`

* Simplify mixnet topology (#393)

* Simplify bytes and duration range ser/de (#394)

* optimize bytes serde and duration serde

---------

Co-authored-by: Al Liu <scygliu1@gmail.com>
Co-authored-by: Daniel Sanchez <sanchez.quiros.daniel@gmail.com>
Co-authored-by: Giacomo Pasini <Zeegomo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Overwatch for mixnode bin
2 participants