Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node_key from cli args #361

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Set node_key from cli args #361

merged 1 commit into from
Aug 31, 2023

Conversation

bacv
Copy link
Member

@bacv bacv commented Aug 31, 2023

Added nomos node cli parameter to override the node key in config.yml file.

@bacv bacv added the node label Aug 31, 2023
@bacv bacv added this to the Nomos testnet (playground) milestone Aug 31, 2023
@bacv bacv self-assigned this Aug 31, 2023
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider loading from env and well. But this is ok for now. Thanks!

@bacv
Copy link
Member Author

bacv commented Aug 31, 2023

I think we should consider loading from env and well. But this is ok for now. Thanks!

I'll look into it, maybe there's a nice way to map that to config. For now I'm just adding a minimal set of params required to spawn small network of nodes. Will update gradually with more.

@bacv bacv merged commit e9b752a into master Aug 31, 2023
3 checks passed
@bacv bacv deleted the node-key-cli-arg branch August 31, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants