Node envconfig #382
Merged
Node envconfig #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al8n
reviewed
Sep 7, 2023
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
danielSanchezQ
approved these changes
Sep 7, 2023
youngjoon-lee
approved these changes
Sep 8, 2023
bacv
force-pushed
the
node-envconfig
branch
from
5ff2825
to
c987d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed some parameters to be configured via the cli or env variables.
If this approach is acceptable, then I'll create a new PR for metrics configuration, as node currently uses MapMetricsBackend instead of Graphql.