Adopt a sans-IO style for DaProtocol #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove async streams from the DaProtocol trait to avoid creating dependencies on actual I/O. The protocol it's now transformed into a state machine with an input and output buffer. In addition, a method to create an attestation was added to the trait.
zeegomo
force-pushed
the
update-da-trait
branch
from
8cdce81
to
4d35b4c
Compare
danielSanchezQ
approved these changes
Sep 12, 2023
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove async streams from the DaProtocol trait to avoid creating dependencies on actual I/O. The protocol it's now transformed into a state machine with an input and output buffer.
In addition, a method to create an attestation was added to the trait.