[nomos-cli] Add command to disseminate data #400
Conversation
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
| loop { | ||
| if let Some(cert) = da.certify_dispersal() { | ||
| terminal_cmd_done(); | ||
| return Ok(cert); | ||
| } | ||
| da.recv_attestation(attestations.next().await.unwrap()); | ||
| } |
There was a problem hiding this comment.
Probably clearer to call recv_attestation prior to certify_dispersal? It's not very important, though.
| tracing::subscriber::set_global_default(tracing_subscriber::FmtSubscriber::new()) | ||
| .expect("setting tracing default failed"); |
There was a problem hiding this comment.
Shouldn't this be on the main function of the binary?
There was a problem hiding this comment.
Not sure everybody is interested in logs. For example, the complete interactive version of this command probably wants to use a different UI without printing node logs. Also, I'm using logs here to catch whatever the node is printing, a command that does not have a running node maybe does not even use tracing logs
There was a problem hiding this comment.
Sure, makes sense, thanks!
| for blob in blobs { | ||
| adapter.send_blob(blob).await.unwrap(); | ||
| } |
There was a problem hiding this comment.
We can send then all at once (they may be a lot of chunks eventually), something like:
let tasks: FuturesUnordered<_> = blobs.map(|blob| tokio::spawnadapter.send_blob(blob))).collect()
future::try_join_all(tasks).await;| // To interact with the network service it's easier to just spawn | ||
| // an overwatch app |
There was a problem hiding this comment.
Not sure if it would have been enough to spawn a NetworkBackend instead.
There was a problem hiding this comment.
I think the Libp2pAdapter likes a NetworkService
There was a problem hiding this comment.
Ah yes indeed, likes it very much!
Add nomos-cli to hold various utilities for the node. To start, this commit adds a command to disseminate some data through the network and build a certificate of correct dispersal for inclusion in a block
danielSanchezQ
force-pushed
the
nomos-cli
branch
from
0b8eaa8
to
13baf27
Compare
Add nomos-cli to hold various utilities for the node.
To start, this commit adds a command to disseminate some
data through the network and build a certificate of correct
dispersal for inclusion in a block.
The idea is to grow this command into an interactive one covering the whole DA and transaction submit process emulating an EZ
Still haven't tested it but not sure we have the corresponding server component in place