Block building core #401
Block building core #401
Conversation
danielSanchezQ
commented
Sep 13, 2023
danielSanchezQ
commented
- Added transactions selections trait
- Added blob selection trait
- Implemented basic size filling tx selector
- Implemented basic size filling blob selector
- Implemented block builder with composing tx+blob selectors
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
nomos-core/src/block/builder.rs
Outdated
| use serde::de::DeserializeOwned; | ||
| use serde::Serialize; |
| use consensus_engine::overlay::RandomBeaconState; | ||
| use consensus_engine::{NodeId, Qc, View}; | ||
|
|
||
| pub struct BlockBuilder<Tx, Blob, TxSelector, BlobSelector> { |
There was a problem hiding this comment.
how would this be used? I think an example might help me understand
There was a problem hiding this comment.
I'm not really sure I understand exactly. But it is just a wrapper over the Block::new that throws into the mix the transaction and blob selectors (Which should be some static heuristic).
Core is the build method:
Block::new(
view,
parent_qc,
tx_selector.select_tx_from(txs),
blob_selector.select_blob_from(blobs),
proposer,
beacon,
)The idea is to just use it when the leader propose the block.
I had in mind that we could even have a service that handles the next block building depending on different events in the node:
- View change
- New tx arrived
- New blob arrived
- ...
So it always have something ready when needed.
But for now I think this is enough.
There was a problem hiding this comment.
how would this be used? I think an example might help me understand
I added an example to the builder, but I do not think that is what you reffered to, hence my answer above.
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
