Simulation branch with one committee fix #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
danielSanchezQ
approved these changes
Sep 13, 2023
|
Thanks, this does appear to fix the issue. Let me run it over a larger dataset and see if everything works as intended; it would take a day, cheers |
0xFugue
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During research simulation runs tree and branch overlays behave as expected, the only issue was that branch overlay timed out without incrementing the view when it contained single committee. This was not the case for flat and tree overlays.
This change fixes the problem, but to be totally sure, I'd like to ask @0xFugue to rerun all tests with this version and check if branch overlay still correlate to tree overlay results with higher committee count.