Add tests for blob dissemination #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeegomo
force-pushed
the
da-disseminate-tests
branch
from
ceb0f72
to
bf0bbd6
Compare
Comment on lines
+46
to
+47
| std::thread::spawn(move || cmd.run().unwrap()) | ||
| .join() | ||
| .unwrap(); |
There was a problem hiding this comment.
why to spawn a thread to immediately join? 🤔
There was a problem hiding this comment.
cmd.run() tries to spawn a new tokio runtime because it's using overwatch. Either we do that on a new thread or we spawn directly a new process by invoking the command on a terminal
Split nomos-cli into lib and bin and make config public so that it can be reused in tests
zeegomo
force-pushed
the
da-disseminate-tests
branch
from
72b350b
to
7b630a8
Compare
danielSanchezQ
approved these changes
Sep 20, 2023
| @@ -174,6 +174,8 @@ impl ServiceCore for DisseminateService { | |||
| .is_err() | |||
| { | |||
| tracing::error!("Timeout reached, check the logs for additional details"); | |||
| service_state.overwatch_handle.shutdown().await; | |||
| std::process::exit(1); | |||
| } | |||
There was a problem hiding this comment.
It seems that we also need to exit the process even if the disseminate() returns an error (within the timeout period). If not, the test will be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.