WIP: Add the metrics recording feature for libp2p
#431
Conversation
| Ok(Swarm { swarm }) | ||
| #[cfg(feature = "metrics")] | ||
| let metrics = { | ||
| let mut metric_registry = Registry::default(); |
There was a problem hiding this comment.
Is it true, that if we'll want to have one prometheus service inside the node (spawned as described in TODO comment) then metrics_registry will need to be passed as reference instead of created here?
There was a problem hiding this comment.
Ah right. I’ll reopen this after checking how this can be used with the existing the metrics service. I think we cannot merge this without figuring out how to use this.
There was a problem hiding this comment.
Hm. I think that the way how libp2p gathers/exposes metrics is not flexible. Even if we add a prometheus backend in our metrics service, we need to pass the reference of prometheus_client::registry::Registry to the libp2p network service, so that it can be used as described in this PR. I don't think that's a good design. Also, it seems that the only way we can query metrics from the Registry is dumping all metrics using the text encoder or others. I think that this way doesn't fit with the design of our metrics service which has update() and load() functions.
I'd like to suggest to postpone this discussion since this topic isn't in priority. Sorry for opening this PR without enough research. Later when we really begin using our metrics service, we can think about how we can adopt prometheus-client (or if it's necessary).
youngjoon-lee
changed the title
metrics recording feature for libp2pmetrics recording feature for libp2p
|
Closing this for now since we don't clearly know which metrics should be collected from network layer in order to measure the quality of privacy. I'll revisit this PR after we develop more dicussions about the network privacy. |
Using libp2p_metrics, we can gather metrics by recording libp2p events. For example, we can record how many messages are received from certain peers. This would be useful for #391 in the future.
TODO: expose libp2p metrics to the metrics service.