Finish the skeleton of the api for nomos-node #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomos-http-api/tests/todo.rs
Outdated
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl Endpoint for TodoEndpoint { |
There was a problem hiding this comment.
This would be more a Webserver than an endpoint right?
There was a problem hiding this comment.
In fact we could call it Backend so it is in the same fashion as other services (?)
There was a problem hiding this comment.
Yeah, it is a web server.
danielSanchezQ
approved these changes
Oct 4, 2023
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be we can change the crate name to
nomos-api? Maybe we also supportgrpcendpoint in the future?The core logic of the PR is not large, but there is a large test case, to test if the swagger docs route works.