Configure supermajority threshold via envvars #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this for exactly? |
Nomos node is now configured to use TreeOverlay, IIRC nomos node won't allow other overlays? nomos-node/nodes/nomos-node/src/lib.rs Line 63 in aa69eec |
But the threshold comes by default right? Or do we override it for testing? |
|
Yes, this is just for testing, the default is 2/3: nomos-node/consensus-engine/src/overlay/tree_overlay/overlay.rs Lines 18 to 22 in aa69eec |
bacv
force-pushed
the
node-supermajority-envvars
branch
from
040b78d
to
9381a62
Compare
danielSanchezQ
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.