-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulations overlay topo info #479
Conversation
pub root_id: CommitteeId, | ||
} | ||
|
||
pub trait OverlayInfoExt { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make it require Overlay
as well to constrain it more, but it ok like that if we want to have some mock at some point:
pub trait OverlayInfoExt : Overlay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning towards leaving it as is for now, until it's required. As I understand, the implementation definition (impl<T: Overlay> OverlayInfoExt for T {
) wouldn't change with pub trait OverlayInfoExt : Overlay
?
impl<T: Overlay> OverlayInfoExt for T { | ||
fn info(&self) -> OverlayInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
4ac2377
to
814637e
Compare
Collecting and saving overlay information during the simulations runs, mainly to visualize the overlay using some other methods.
Tested on a temp branch rebased on #478, example output: