Add Sigkill handling to node binary #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
requested review from
zeegomo and
bacv
and removed request for
zeegomo
danielSanchezQ
force-pushed
the
sigkill-handling
branch
from
33ade29
to
f79c25a
Compare
bacv
approved these changes
Oct 25, 2023
nomos-services/system-sig/src/lib.rs
Outdated
| async fn should_stop_service(msg: LifecycleMessage) -> bool { | ||
| match msg { | ||
| LifecycleMessage::Shutdown(sender) => { | ||
| // TODO: Try to finish pending transactions if any and close connections properly |
There was a problem hiding this comment.
I believe there won't be any pending txs in this service
There was a problem hiding this comment.
hopefully not 😅
danielSanchezQ
force-pushed
the
sigkill-handling
branch
from
f79c25a
to
3bda511
Compare
youngjoon-lee
approved these changes
Oct 30, 2023
danielSanchezQ
force-pushed
the
sigkill-handling
branch
from
5dbb11b
to
82dee8f
Compare
|
CI codeconv was unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.