Remove block contents from mempool #485
Conversation
zeegomo
force-pushed
the
mark-items-in-block
branch
from
da98381
to
dbf71cd
Compare
| pub trait Attestation { | ||
| type Blob: Blob; | ||
| type Hash: Hash + Eq + Clone; | ||
| fn blob(&self) -> <Self::Blob as Blob>::Hash; | ||
| fn hash(&self) -> <Self::Blob as Blob>::Hash; | ||
| fn hash(&self) -> Self::Hash; | ||
| fn as_bytes(&self) -> Bytes; | ||
| } |
There was a problem hiding this comment.
Why adding the Hash associated type? Reasoning for using the blob one was to mark that the return hash is not the attestation/certificate/whatever but the related blob one. Which now that I think of it it makes sense at type level but maybe not so much as it cannot be enforced (neither I added documentation, completely wrong on my side).
There was a problem hiding this comment.
Reasoning for using the blob one was to mark that the return hash is not the attestation/certificate/whatever but the related blob one.
For that we have the blob method. Attestations and certificates could be for the same blob but still be different (e.g. produced by different nodes) and we need a way to differentiate those.
Why adding the Hash associated type?
In theory we could reuse the blob type to enforce that all the items for DA use the same hash type but I could not find a way to write a generic constraint like Attestation<Blob::Hash = T> (rust-lang/rust#52662), so I had to add this as a separate trait instead
Let's signal to the mempool which items were included in a block already to avoid reinclusion.