Add storage api for new http backend #488
Conversation
| @@ -29,6 +29,7 @@ pub struct AxumBackendSettings { | |||
| pub cl: OverwatchHandle, | |||
| pub carnot: OverwatchHandle, | |||
| pub network: OverwatchHandle, | |||
| pub storage: OverwatchHandle, | |||
There was a problem hiding this comment.
why do we have multiple overwatch handle copies?
There was a problem hiding this comment.
Yep, I was wondering the same. But I have seen this is removed in a different PR?
There was a problem hiding this comment.
Yeah, in the final PR, there is only one left.
There was a problem hiding this comment.
Would it be hard to not add them here instead?
There was a problem hiding this comment.
It is not hard, actually. I also considered removing copies in the initial PR (metrics-api), but there are some small refactors on trait design in the final PR, and the metrics-api one has already been reviewed. So, I chose to remove these handles in the final PR.
There was a problem hiding this comment.
It's not clear what is the final PR. If you open PRs with a specific sequence in mind please put it in the title (e.g. API refactor [2/5] - storage) or description
There was a problem hiding this comment.
Sorry for the misleading. The final PR is #490. I will do this next time.
No description provided.