Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional port conflict in CLI integration test #504

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

youngjoon-lee
Copy link
Contributor

The dessemination CLI integration test sometimes fails with the following error.
https://github.com/logos-co/nomos-node/actions/runs/6730826847/job/18294274937

thread 'Overwatch' panicked at nomos-services/network/src/backends/libp2p/swarm.rs:54:49:
called `Result::unwrap()` on an `Err` value: Other(Custom { kind: Other, error: Transport(Custom { kind: Other, error: Other(Left(Left(Os { code: 98, kind: AddrInUse, message: "Address already in use" }))) }) })

It's because the test kills one of the running nomos-nodes (using SIGKILL) and reuses its network_config to run the CLI. But, it seems that the libp2p port is sometimes not closed immediately by OS.

Instead, I changed it to use a new port for CLI.

@youngjoon-lee youngjoon-lee added this to the DA milestone Nov 2, 2023
@youngjoon-lee youngjoon-lee self-assigned this Nov 2, 2023
@youngjoon-lee youngjoon-lee merged commit 1c9528e into master Nov 5, 2023
7 checks passed
@youngjoon-lee youngjoon-lee deleted the cli-test-port-conflict branch November 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants