Do not skip Block::id during ser/de #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block.id is a necessary piece of information in the context of the consensus engine since there it's not possible to recover the id of the block since the contents are not available. Instead, we should only skip that field when serializing/deserializing a full block.
zeegomo
force-pushed
the
do-not-skip-id
branch
from
941c504
to
c5d5983
Compare
al8n
approved these changes
Nov 3, 2023
youngjoon-lee
approved these changes
Nov 3, 2023
|
I see the point. Is this because we check within the consensus API and then it goes missing right? |
danielSanchezQ
approved these changes
Nov 3, 2023
Because you can get it by hashing the contents of the block. |
zeegomo
added a commit
that referenced
this pull request
Nov 3, 2023
Block.id is a necessary piece of information in the context of the consensus engine since there it's not possible to recover the id of the block since the contents are not available. Instead, we should only skip that field when serializing/deserializing a full block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block.id is a necessary piece of information in the context of the consensus engine since there it's not possible to recover the id of the block since the contents are not available. Instead, we should only skip that field when serializing/deserializing a full block.