-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block_info
api for new HTTP service
#509
Conversation
Consensus info was returning the full list of blocks even though that can get quite large with time. Instead, this commit change that API to return a constant size message and adds a new one to return a chain of blocks with user specified endings.
Co-authored-by: Youngjoon Lee <taxihighway@gmail.com>
@@ -85,6 +89,7 @@ where | |||
.route("/cl/metrics", routing::get(cl_metrics::<T>)) | |||
.route("/cl/status", routing::post(cl_status::<T>)) | |||
.route("/carnot/info", routing::get(carnot_info::<T, S, SIZE>)) | |||
.route("/block/info", routing::get(block_info::<T, S, SIZE>)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/carnot/blocks
probably? based on #502.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think we also need to rename the function name block_info
to carnot_blocks
(or something else).
Based on #502.