Da voter config for docker compose #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
approved these changes
Nov 6, 2023
nodes/nomos-node/src/config.rs
Outdated
Comment on lines
274
to
280
| pub fn update_da(mut self, da_args: DaArgs) -> Result<Self> { | ||
| let DaArgs { da_voter_key } = da_args; | ||
|
|
||
| if let Some(private_key) = da_voter_key { | ||
| let bytes = <[u8; 32]>::from_hex(private_key)?; | ||
| self.da.da_protocol.voter = bytes; | ||
| } |
There was a problem hiding this comment.
Thank you. I forgot to add this function here.
I think it might be clearer to not call this private key, since we don't know yet what will be used for the voter, as discussed in #498 (comment) (even though we'll anyway use the same private key as the consensus service for now).
There was a problem hiding this comment.
Thanks, that makes sense! Updated.
zeegomo
approved these changes
Nov 7, 2023
bacv
force-pushed
the
docker-compose-da-voter
branch
5 times, most recently
from
a116492
to
d151529
Compare
bacv
force-pushed
the
docker-compose-da-voter
branch
from
8eb3d08
to
52ce159
Compare
|
Just for FYI, github didn't let me merge, because for some reason commits were not signed. Even after updating the signing key, I had to sign every commit in this PR. Did it with this command: |
al8n
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Readd docker build context * Configurable da protocol voter * Do not use private key naming for da voter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable da voter and minor improvements to docker compose file.
A copy of this closed PR: #512