[WIP] DA read range api #546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use dummy default private_key in dissemination app
| @@ -47,6 +48,7 @@ impl Disseminate { | |||
| let output = self.output.clone(); | |||
| let (payload_sender, payload_rx) = tokio::sync::mpsc::unbounded_channel(); | |||
| payload_sender.send(bytes).unwrap(); | |||
| let private_key = PrivateKey::default(); // TODO: pass private_key via the cli args. | |||
There was a problem hiding this comment.
Uhm, what is this key used for? Shouldn't be the node itself the one to actually sign stuff?
There was a problem hiding this comment.
I've used this code to discuss an idea on how blob structure should look like, I'll summarize the discussion in the document. In short, this was added as proposal for blob validation during dissemination (before cert is created), but the idea was discarded.
Comment on lines
14
to
+24
| pub trait DaProtocol { | ||
| type Blob: Blob; | ||
| type Auth: BlobAuth; | ||
| type Attestation: Attestation; | ||
| type Certificate: Certificate; | ||
| type Settings: Clone; | ||
|
|
||
| // Construct a new instance | ||
| fn new(settings: Self::Settings) -> Self; | ||
| /// Encode bytes into blobs | ||
| fn encode<T: AsRef<[u8]>>(&self, data: T) -> Vec<Self::Blob>; | ||
| fn encode<T: AsRef<[u8]>>(&self, auth: Self::Auth, data: T) -> Vec<Self::Blob>; |
There was a problem hiding this comment.
I think this is part of the message itself not the blob per se, unless I am missing something.
|
Closing this as blob validation is not in a scope at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof of concept DA api for blob retrieval by range, mostly for seeing and discussing what parts of various services need to be updated.